On Fri, May 31, 2024 at 3:49 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 31/05/2024 11:04, Animesh Agarwal wrote:
> > + "#dma-cells":
> > + const: 1
> > +
> > + dma-channels:
> > + maximum: 16
>
> maximum or const?
The txt binding says it should always be 16. Datasheet says this
device has 16 channels of DMA services. I thought specifying just the
maximum implies maximum=minimum=16. Sorry for missing the changelog in
this version it was cost in the v1 of this patch.
>
> deprecated: true
>
Shall it not be
"#dma-channels ":
deprecated: true
?
> > +
> > + dma-requests:
> > + description: Number of DMA requests supported.
>
> deprecated: true
>
Shall it not be
"#dma-requests ":
deprecated: true
?
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - "#dma-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + dma-controller@10001000 {
> > + compatible = "fsl,imx27-dma";
> > + reg = <0x10001000 0x1000>;
> > + interrupts = <32 33>;
> > + #dma-cells = <1>;
> > + dma-channels = <16>;
>
> and drop it from here
Is this really a deprecated property?
