* Bryan O'Donoghue (bryan.odonoghue@xxxxxxxxxx) wrote:
> On 16/05/2024 17:25, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >
> > Remove unused struct 'reg_info'
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > ---
> > drivers/dma/qcom/gpi.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > index 1c93864e0e4d..639ab304db9b 100644
> > --- a/drivers/dma/qcom/gpi.c
> > +++ b/drivers/dma/qcom/gpi.c
> > @@ -476,12 +476,6 @@ struct gpi_dev {
> > struct gpii *gpiis;
> > };
> > -struct reg_info {
> > - char *name;
> > - u32 offset;
> > - u32 val;
> > -};
> > -
> > struct gchan {
> > struct virt_dma_chan vc;
> > u32 chid;
Hi Bryan,
> More detail in the commit log please - is the structure unused ? What is the
> provenance of it being added and becoming dead code.
>
> More detail required here.
If you look at the V1 I had
''gpi_desc' seems like it was never used.
Remove it.'
but Frank suggested copying the subject line; so I'm not sure
whether you want more or less!
I could change this to:
'gpi_desc' was never used since it's initial
commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
Would you be OK with that?
Dave
>
> ---
> bod
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
