On Tue, Apr 09, 2024 at 10:02:32PM +0200, Krzysztof Kozlowski wrote: > On 09/04/2024 20:54, Frank Li wrote: > > fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from > > required and add 'if' block for other compatible string to keep the same > > restrictions. > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > --- > > > > Notes: > > Change from v2 to v3 > > - rebase to dmaengine/next > > This fails... What's wrong? https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/log/?h=next > > > > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > > index 825f4715499e5..657a7d3ebf857 100644 > > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml > > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > > @@ -82,7 +82,6 @@ required: > > - compatible > > - reg > > - interrupts > > - - clocks > > - dma-channels > > > > allOf: > > @@ -187,6 +186,22 @@ allOf: > > "#dma-cells": > > const: 3 > > > > + - if: > > + properties: > > + compatible: > > + contains: > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. Strange, Test passed make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/dma/fsl,edma.example.dts CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb > > Best regards, > Krzysztof >
