> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, 27 March, 2024 3:50 PM > To: ChunHau Tan <chunhau.tan@xxxxxxxxxxxxxxxx>; Eugeniy Paltsev > <Eugeniy.Paltsev@xxxxxxxxxxxx>; Vinod Koul <vkoul@xxxxxxxxxx>; Rob Herring > <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; > Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; JeeHeng Sia > <jeeheng.sia@xxxxxxxxxxxxxxxx>; dmaengine@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 > support > > On 27/03/2024 03:51, Tan Chun Hau wrote: > > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA > > controller. > > > > Both JH8100 and JH7110 require reset operation in device probe. > > However, JH8100 doesn't need to apply different configuration on > > CH_CFG registers. > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, > under or above your Signed-off-by tag. Tag is "received", when provided in a > message replied to you on the mailing list. Tools like b4 can help here. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for tags received on the version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitt > ing-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. Hi Krzysztof, thank you very much for the feedback, Sorry I overlooked it. Do you prefer I resend V2 patch or send a V3 patch to include the Acked-by ? Thank you. > > Best regards, > Krzysztof
