> -----Original Message----- > From: Conor Dooley <conor@xxxxxxxxxx> > Sent: Wednesday, 27 March, 2024 2:33 AM > To: ChunHau Tan <chunhau.tan@xxxxxxxxxxxxxxxx> > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>; Vinod Koul > <vkoul@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > Leyfoon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx>; JeeHeng Sia > <jeeheng.sia@xxxxxxxxxxxxxxxx>; dmaengine@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 > support > > On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote: > > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA > > controller. > > Your commit message should explain what makes this incompatible with existing > devices. That inforatiion does appear to be in the driver patch, but should also be > here. Otherwise, > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Okay, thank you for the feedback. > > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@xxxxxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > index 363cf8bd150d..525f5f3932f5 100644 > > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > @@ -21,6 +21,7 @@ properties: > > - snps,axi-dma-1.01a > > - intel,kmb-axi-dma > > - starfive,jh7110-axi-dma > > + - starfive,jh8100-axi-dma > > > > reg: > > minItems: 1 > > -- > > 2.25.1 > >
