On Mon, Mar 18, 2024 at 09:04:37AM +0100, Krzysztof Kozlowski wrote: > On 18/03/2024 07:38, Inochi Amaoto wrote: > > CV18XX/SG200X series SoCs have a special top misc system controller, > > which provides register access for several devices. In addition to > > register access, this system controller also contains some subdevices > > (such as dmamux). > > > > Add bindings for top misc controller of CV18XX/SG200X series SoC. > > > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx> > > --- > > .../soc/sophgo/sophgo,cv1800-top-syscon.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml > > new file mode 100644 > > index 000000000000..009e45e520d9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800-top-syscon.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/sophgo/sophgo,cv1800-top-syscon.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo CV1800/SG2000 SoC top system controller > > + > > +maintainers: > > + - Inochi Amaoto <inochiama@xxxxxxxxxxx> > > + > > +description: > > + The Sophgo CV1800/SG2000 SoC top misc system controller provides > > + register access to configure related modules. > > + > > +properties: > > + compatible: > > + items: > > + - const: sophgo,cv1800-top-syscon > > + - const: syscon > > + - const: simple-mfd > > + > > + reg: > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: > > + type: object > > You have schema for the child, don't you? So use it: add 'dma-router' to > the properties with $ref. additionalProperties: false. > > Explain the dependencies and merging bindings via one tree in the cover > letter or commit changelog. > Thanks for this suggestion. This is what I need. > Best regards, > Krzysztof >