On 2/20/2024 1:40 AM, Tadeusz Struk wrote:
> The PTDMA driver sets DMA masks in two different places for the same
> device inconsistently. First call is in pt_pci_probe(), where it uses
> 48bit mask. The second call is in pt_dmaengine_register(), where it
> uses a 64bit mask. Using 64bit dma mask causes IO_PAGE_FAULT errors
> on DMA transfers between main memory and other devices.
> Without the extra call it works fine. Additionally the second call
> doesn't check the return value so it can silently fail.
> Remove the superfluous dma_set_mask() call and only use 48bit mask.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA resource")
>
> Signed-off-by: Tadeusz Struk <tstruk@xxxxxxxxxx>
> ---
> drivers/dma/ptdma/ptdma-dmaengine.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/ptdma/ptdma-dmaengine.c b/drivers/dma/ptdma/ptdma-dmaengine.c
> index 1aa65e5de0f3..f79240734807 100644
> --- a/drivers/dma/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/ptdma/ptdma-dmaengine.c
> @@ -385,8 +385,6 @@ int pt_dmaengine_register(struct pt_device *pt)
> chan->vc.desc_free = pt_do_cleanup;
> vchan_init(&chan->vc, dma_dev);
>
> - dma_set_mask_and_coherent(pt->dev, DMA_BIT_MASK(64));
> -
Looks good to me
Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> ret = dma_async_device_register(dma_dev);
> if (ret)
> goto err_reg;
