On 09-02-24, 16:08, Frank Li wrote: > Fix below sparse warnings. > > drivers/dma/fsl-qdma.c:645:50: sparse: warning: incorrect type in argument 2 (different address spaces) > drivers/dma/fsl-qdma.c:645:50: sparse: expected void [noderef] __iomem *addr > drivers/dma/fsl-qdma.c:645:50: sparse: got void > > drivers/dma/fsl-qdma.c:387:15: sparse: sparse: restricted __le32 degrades to integer > drivers/dma/fsl-qdma.c:390:19: sparse: expected restricted __le64 [usertype] data > drivers/dma/fsl-qdma.c:392:13: sparse: expected unsigned int [assigned] [usertype] cmd Please document why you are adding the annotations Also I see this after the patch: dmaengine/drivers/dma/fsl-edma-main.c:56:16: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-main.c:60:9: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:76:15: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:93:9: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:100:22: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:101:25: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:104:15: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:106:9: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:131:19: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:137:17: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:140:9: warning: cast removes address space '__iomem' of expression CC [M] drivers/dma/idma64.o dmaengine/drivers/dma/fsl-edma-common.c:473:17: warning: cast removes address space '__iomem' of expression dmaengine/drivers/dma/fsl-edma-common.c:473:17: warning: cast removes address space '__iomem' of expression > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202402081929.mggOTHaZ-lkp@xxxxxxxxx/ > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > drivers/dma/fsl-qdma.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c > index 1e3bf6f30f784..5005e138fc239 100644 > --- a/drivers/dma/fsl-qdma.c > +++ b/drivers/dma/fsl-qdma.c > @@ -161,6 +161,10 @@ struct fsl_qdma_format { > u8 __reserved1[2]; > u8 cfg8b_w1; > } __packed; > + struct { > + __le32 __reserved2; > + __le32 cmd; > + } __packed; > __le64 data; > }; > } __packed; > @@ -355,7 +359,6 @@ static void fsl_qdma_free_chan_resources(struct dma_chan *chan) > static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp, > dma_addr_t dst, dma_addr_t src, u32 len) > { > - u32 cmd; > struct fsl_qdma_format *sdf, *ddf; > struct fsl_qdma_format *ccdf, *csgf_desc, *csgf_src, *csgf_dest; > > @@ -384,15 +387,11 @@ static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp, > /* This entry is the last entry. */ > qdma_csgf_set_f(csgf_dest, len); > /* Descriptor Buffer */ > - cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE << > - FSL_QDMA_CMD_RWTTYPE_OFFSET) | > - FSL_QDMA_CMD_PF; > - sdf->data = QDMA_SDDF_CMD(cmd); > - > - cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE << > - FSL_QDMA_CMD_RWTTYPE_OFFSET); > - cmd |= cpu_to_le32(FSL_QDMA_CMD_LWC << FSL_QDMA_CMD_LWC_OFFSET); > - ddf->data = QDMA_SDDF_CMD(cmd); > + sdf->cmd = cpu_to_le32((FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET) | > + FSL_QDMA_CMD_PF); > + > + ddf->cmd = cpu_to_le32((FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET) | > + (FSL_QDMA_CMD_LWC << FSL_QDMA_CMD_LWC_OFFSET)); > } > > /* > @@ -626,7 +625,7 @@ static int fsl_qdma_halt(struct fsl_qdma_engine *fsl_qdma) > > static int > fsl_qdma_queue_transfer_complete(struct fsl_qdma_engine *fsl_qdma, > - void *block, > + __iomem void *block, > int id) > { > bool duplicate; > -- > 2.34.1 -- ~Vinod
