On Wed, Nov 22, 2023 at 12:00:17PM +0300, Nikita Shubin wrote:
> Remove DMA platform header, from now on we use device tree for dma
DMA
> clients.
...
> + if (device_is_compatible(chan->device->dev, "cirrus,ep9301-dma-m2p"))
> + return true;
> +
> + return !strcmp(dev_name(chan->device->dev), "ep93xx-dma-m2p");
Haven't you introduced an inliner with the similar flow? Why not reuse it?
...
> +/**
> + * ep93xx_dma_chan_direction - returns direction the channel can be used
> + * @chan: channel
> + *
> + * This function can be used in filter functions to find out whether the
> + * channel supports given DMA direction. Only M2P channels have such
> + * limitation, for M2M channels the direction is configurable.
I believe
scripts/kernel-doc -v -none -Wall ...
against this file (and maybe others!) will complain ("no return section"
or alike).
> + */
--
With Best Regards,
Andy Shevchenko
