Re: [PATCH v6 2/2] dt-bindings: dma: HiSilicon: Add bindings for HiSilicon Ascend sdma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 26, 2023 at 03:25:49PM +0800, Guo Mengqi wrote:
> Add device-tree binding documentation for sdma hardware on
> HiSilicon Ascend SoC families.
> 
> Signed-off-by: Guo Mengqi <guomengqi3@xxxxxxxxxx>
> ---

This is where you explain any expected failure. Resending the same patch 
with the same failure again is not a great strategy. The patch needs to 
stand on its own and not rely on some explanation in a prior version.

>  .../bindings/dma/hisilicon,ascend-sdma.yaml   | 73 +++++++++++++++++++
>  1 file changed, 73 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

I had missed that pasid-num-bits and dma-can-stall are IOMMU consumer 
properties. (We really should have prefixed them with 'iommu'.) I've now 
added them to dtschema which should fix the warning.

Rob



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux