On Sat, Sep 30, 2023 at 09:11:04AM +0200, Greg KH wrote: > On Fri, Sep 29, 2023 at 12:49:20PM -0400, Frank Li wrote: > > ld: fs/debugfs/file.o: in function `debugfs_print_regs': > > file.c:(.text+0x95a): undefined reference to `ioread64be' > > >> ld: file.c:(.text+0x9dd): undefined reference to `ioread64' > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Closes: https://lore.kernel.org/oe-kbuild-all/202309291322.3pZiyosI-lkp@xxxxxxxxx/ > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > What commit id does this fix? In dmaengine tree https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/log/?h=next commit 09289d0ad1226c4735f8d9f68c9c3e54cbaba3d4 Author: Frank Li <Frank.Li@xxxxxxx> Date: Thu Sep 21 11:01:42 2023 -0400 debugfs_create_regset32() support 8/16/64 bit width registers > > > --- > > fs/debugfs/file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c > > index 5b8d4fd7c747..b406283806d9 100644 > > --- a/fs/debugfs/file.c > > +++ b/fs/debugfs/file.c > > @@ -1179,7 +1179,7 @@ void debugfs_print_regs(struct seq_file *s, const struct debugfs_reg *regs, > > seq_printf(s, "%s = 0x%04x\n", regs->name, > > b ? ioread16be(reg) : ioread16(reg)); > > break; > > -#ifdef CONFIG_64BIT > > +#if defined(ioread64) && defined (ioread64be) > > Are you sure this is equivalent? What if these are functions? Just dump 64bit register value. I am not sure why powerpc have not implement this function with CONFIG_64BIT. in io.h #ifndef ioread64 #define ioread64 ioread64 ... #endif I think it is better why to check if ioread64 exist. Frank > > thanks, > > greg k-h
