Dne torek, 19. september 2023 ob 15:31:54 CEST je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> Best regards, Jernej > --- > drivers/dma/sun6i-dma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 2469efddf540..583bf49031cf 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -1470,7 +1470,7 @@ static int sun6i_dma_probe(struct platform_device > *pdev) return ret; > } > > -static int sun6i_dma_remove(struct platform_device *pdev) > +static void sun6i_dma_remove(struct platform_device *pdev) > { > struct sun6i_dma_dev *sdc = platform_get_drvdata(pdev); > > @@ -1484,13 +1484,11 @@ static int sun6i_dma_remove(struct platform_device > *pdev) reset_control_assert(sdc->rstc); > > sun6i_dma_free(sdc); > - > - return 0; > } > > static struct platform_driver sun6i_dma_driver = { > .probe = sun6i_dma_probe, > - .remove = sun6i_dma_remove, > + .remove_new = sun6i_dma_remove, > .driver = { > .name = "sun6i-dma", > .of_match_table = sun6i_dma_match,