Re: [PATCH 09/59] dma: dma-jz4780: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, Sep 19, 2023 at 03:39:10PM +0200, Paul Cercueil wrote:
> Hi Uwe,
> Le mardi 19 septembre 2023 à 15:31 +0200, Uwe Kleine-König a écrit :
> > The .remove() callback for a platform driver returns an int which
> > makes
> > many driver authors wrongly assume it's possible to do error handling
> > by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource
> > leaks.
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new() which already returns void. Eventually after all
> > drivers
> > are converted, .remove_new() is renamed to .remove().
> "is renamed" -> "will be renamed"?

I guess you're right here. I fixed that in my template, but I won't
resend this series (and the others with the same issue) for now.


Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | |

Attachment: signature.asc
Description: PGP signature

[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux