Re: [PATCH V2] dmaengine: sprd: add dma mask interface in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 9/19/2023 10:30 AM, Kaiwei Liu wrote:
In the probe of DMA, the default addressing range is 32 bits,
while the actual DMA hardware addressing range used is 36 bits.
So add dma_set_mask_and_coherent function to match DMA
addressing range.

Signed-off-by: Kaiwei Liu <kaiwei.liu@xxxxxxxxxx>
Change in V2:
-Change subject line.
-Modify error message to make it more readable.

Have you modified the error message against v1? I did not see it.

  drivers/dma/sprd-dma.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 20c3cb1ef2f5..0e146550dfbb 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -1115,6 +1115,15 @@ static int sprd_dma_probe(struct platform_device *pdev)
  	u32 chn_count;
  	int ret, i;
+ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(36));
+	if (ret) {
+		ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
+		if (ret) {
+			dev_err(&pdev->dev, "dma_set_mask_and_coherent failed\n");
+			return ret;
+		}
+	}
  	/* Parse new and deprecated dma-channels properties */
  	ret = device_property_read_u32(&pdev->dev, "dma-channels", &chn_count);
  	if (ret)

[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux