Re: [PATCH v2] dmaengine: idxd: Remove redundant memset() for eventlog allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 8/29/23 11:00, coolrrsh@xxxxxxxxx wrote:
From: Rajeshwar R Shinde <coolrrsh@xxxxxxxxx>

dma_alloc_coherent function already zeroes the array 'addr'.
So, memset function call is not needed.

This fixes warning such as:
WARNING: dma_alloc_coherent used in addr already zeroes out memory,
so memset is not needed.

Signed-off-by: Rajeshwar R Shinde <coolrrsh@xxxxxxxxx>
Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>

Renamed the subject line
  drivers/dma/idxd/device.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 5abbcc61c528..7c74bc60f582 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -786,8 +786,6 @@ static int idxd_device_evl_setup(struct idxd_device *idxd)
  		goto err_alloc;
- memset(addr, 0, size);
  	evl->log = addr;
  	evl->dma = dma_addr;

[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux