Re: [PATCH v2] dmaengine: plx_dma: Fix potential deadlock on &plxdev->ring_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hello Chengfeng,

Am 29.08.2023 um 05:10 schrieb Chengfeng Ye:
Hi Eric,

Thank you for your interest in it.

Thanks for getting back to me.

For a dynamic detection solution, then the answer is yes.
Lockdep, which should be enabled by CONFIG_DEBUG_SPINLOCK,
has the ability to detect such deadlocks. But the problem is that the detection
requires input and exact thread interleaving to trigger the bug, otherwise
the bugs would be buried and cannot be detected.

For static analysis, I think the answer is no. Smatch, like other
static deadlock detection algorithms in CBMC[1] and Infer[2], should be
designed to reason thread interaction but not interrupts, which requires
new algorithms that I am working on.

Will you publish your work later on e.g. on github?
Actually maybe it would even make sense to integrate your work into scripts/ of the Linux kernel (or the like). Basically if a patch to be committed fails locking it should not be committed anyway. IMHO the quality standard one could expect from the code should always be the same. So adding it to a mandatory check procedure (script which must be executed before committing patches) and/or to "0-DAY CI Kernel Test Service" [5] would definitely be worth a thought.

Besides, may I ask a question that I have sent some patches[3][4] weeks
ago, but have not yet got a reply. Would reviewers check the patches
later or should I ping them again?

You never have a guarantee who will when review your patch on the mailing list. It is kind of best effort based system mainly of volunteers.
Just give people a bit of time since it is currently also holiday time.
You may ping the maintainer of the subsystem when some time has passed since he is responsible for the patches to be administered.
BTW, I think you already pinged indirectly w/ your e-mail.




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux