> From: Baolu Lu <baolu.lu@xxxxxxxxxxxxxxx> > Sent: Friday, May 26, 2023 10:43 AM > > > > >> + > >> + ret = domain_attach_iommu(dmar_domain, iommu); > >> + if (ret) > >> + goto out_free; > >> + > >> + if (domain_type_is_si(dmar_domain)) > >> + ret = intel_pasid_setup_pass_through(iommu, dmar_domain, > >> + dev, pasid); > >> + else if (dmar_domain->use_first_level) > >> + ret = domain_setup_first_level(iommu, dmar_domain, > >> + dev, pasid); > >> + else > >> + ret = intel_pasid_setup_second_level(iommu, dmar_domain, > >> + dev, pasid); > > > > Here you allow attaching pasid to a domain using second-level but all > > prior changes are only for first-level. > > As explained, prior changes are for pasid-base iotlb invalidation for > first level page table change. Or perhaps I didn't get you correctly? > No. you are correct.