Re: [PATCH 1/2] dt-bindings: dmaengine: Add Loongson LS2X APB DMA controller

[Conor Dooley <conor@xxxxxxxxxx>]

On Wed, May 31, 2023 at 04:50:04PM +0800, Binbin Zhou wrote:
> Add Loongson LS2X APB DMA controller binding with DT schema
> format using json-schema.
> 
> Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> ---
>  .../bindings/dma/loongson,ls2x-apbdma.yaml    | 61 +++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/loongson,ls2x-apbdma.yaml
> 
> diff --git a/Documentation/devicetree/bindings/dma/loongson,ls2x-apbdma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls2x-apbdma.yaml
> new file mode 100644
> index 000000000000..9df32dd98aaf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/loongson,ls2x-apbdma.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/loongson,ls2x-apbdma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson LS2X APB DMA controller
> +
> +description: |

As a minor nit, the | shouldn't be required here.

> +  The Loongson LS2X APB DMA controller is used for transferring data
> +  between system memory and the peripherals on the APB bus.
> +
> +maintainers:
> +  - Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: loongson,ls2k1000-apbdma
> +      - items:
> +          - const: loongson,ls2k0500-apbdma
> +          - const: loongson,ls2k1000-apbdma

Sweet, good to see fallbacks in use here ;)

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#dma-cells":
> +    const: 1
> +
> +  dma-channels:
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#dma-cells"
> +  - dma-channels
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    apbdma0: dma-controller@1fe00c00 {

Nothing references the apbdma0 label so it can be dropped.
Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> +        compatible = "loongson,ls2k1000-apbdma";
> +        reg = <0x1fe00c00 0x8>;
> +        interrupt-parent = <&liointc1>;
> +        interrupts = <12 IRQ_TYPE_LEVEL_HIGH>;
> +        #dma-cells = <1>;
> +        dma-channels = <1>;
> +    };
> +
> +...
> -- 
> 2.39.1
>

Attachment: signature.asc
Description: PGP signature