Hey Randy, On Mon, May 22, 2023 at 05:06:06PM -0700, Randy Dunlap wrote: > "_start" is used in several arches and proably should be reserved > for ARCH usage. Using it in a driver for a private symbol can cause > a build error when it conflicts with ARCH usage of the same symbol. > > Therefore rename pl330's "_start" to "_start_thread" so that there > is no conflict and no build error. _start_thread() seems pretty generic to me too, but there don't appear to be any users & it is certainly better than the one causing build issues! Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor. > > drivers/dma/pl330.c:1053:13: error: '_start' redeclared as different kind of symbol > 1053 | static bool _start(struct pl330_thread *thrd) > | ^~~~~~ > In file included from ../include/linux/interrupt.h:21, > from ../drivers/dma/pl330.c:18: > arch/riscv/include/asm/sections.h:11:13: note: previous declaration of '_start' with type 'char[]' > 11 | extern char _start[]; > | ^~~~~~
Attachment:
signature.asc
Description: PGP signature
