> +/* > + * Use vender/device and class to identify the DMA function. > + */ > +#define SWITCHTEC_DMA_DEVICE(device_id) \ I'd word this as: /* * Also use the class code to identify the devices, as some of the * device IDs are also used for other devices with other classes by * Microsemi. */ to emphasis on why this macro even exists. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>