Hi Bjorn, Vinod, Mani On Fri, Apr 14, 2023 at 05:18:18AM +0300, Serge Semin wrote: > It turns out the recent DW PCIe-related patchset was merged in with > several relatively trivial issues left unsettled (noted by Bjorn and > Manivannan). All of these lefovers have been fixed in this patchset. > Namely the series starts with two bug-fixes. The first one concerns the > improper link-mode initialization in case if the CDM-check is enabled. The > second unfortunate mistake I made in the IP-core version type helper. In > particular instead of testing the IP-core version type the macro function > referred to the just IP-core version which obviously wasn't what I > intended. > > Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning > message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". > Secondly the Baikal-T1 PCIe Host driver is converted to perform the > asynchronous probe type which saved us of about 15% of bootup time if no any > PCIe peripheral device attached to the port. > > Then the patchset contains the Baikal-T1 PCIe driver fix. The > corresponding patch removes the false error message printed during the > controller probe procedure. I accidentally added the unconditional > dev_err_probe() method invocation. It was obviously wrong. > > Then two trivial cleanups are introduced. The first one concerns the > duplicated fast-link-mode flag unsetting. The second one implies > dropping a redundant empty line from the dw_pcie_link_set_max_speed() > function. > > The series continues with a patch inspired by the last @Bjorn note > regarding the generic resources request interface. As @Bjorn correctly > said it would be nice to have the new interface used wider in the DW PCIe > subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti > PCIe driver can be easily converted to using the generic clock names. > That's what is done in the noted patch. > > The patchset is closed with a series of MAINTAINERS-list related patches. > Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to > update the MAINTAINER-list with the new files added in the framework of > that procedure. All the snps,dw-pcie* schemas shall be maintained by the > DW PCIe core driver maintainers. Secondly seeing how long it took for my > patchsets to review and not having any comments from the original driver > maintainers I'd suggest to add myself as the reviewer to the DW PCIe and > eDMA drivers. Thus hopefully the new updates review process will be > performed with much less latencies. For the same reason @Manivannan is > added to the maintainers list of the DW PCIe/eDMA drivers as he already > agreed to be in. @Bjorn, anything to say about this patchset? If you are ok with the changes please merge in the PCI patches. @Vinod, as you requested the series has been extended with the patches based on v3 discussion. Please have a look. @Mani, the series has been updated with the patches adding you as the DW PCIe/eDMA maintainer as per your permission retrieved on v3. -Serge(y) > > Link: https://lore.kernel.org/linux-pci/20230217093956.27126-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/ > Changelog v2: > - Rebase onto the kernel 6.3-rc2. > > Link: https://lore.kernel.org/linux-pci/20230313200816.30105-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/ > Changelog v3: > - Drop the patch: > [PATCH v2 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled > and rebase onto the already submitted by @Yoshihiro fix: > commit cdce67099117 ("PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled") > - Just resend. > > Link: https://lore.kernel.org/linux-pci/20230411033928.30397-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/ > Changelog v4: > - Demote @Gustavo to being DW PCIe/eDMA drivers reviewer: > [PATCH v4 9/14] MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer > [PATCH v4 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer > - Add Manivannan to the DW PCIe/eDMA drivers maintainers list: > [PATCH v4 10/14] MAINTAINERS: Add Manivannan to DW PCIe core maintainers list > [PATCH v4 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@xxxxxxxxxxxxxxxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx > Cc: dmaengine@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Serge Semin (14): > PCI: dwc: Fix erroneous version type test helper > PCI: dwc: Fix inbound iATU entries out-of-bounds warning message > PCI: bt1: Enable async probe type > PCI: bt1: Fix printing false error message > PCI: dwc: Drop duplicated fast-link-mode flag unsetting > PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() > PCI: visconti: Convert to using generic resources getter > MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas > MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer > MAINTAINERS: Add Manivannan to DW PCIe core maintainers list > MAINTAINERS: Add myself as the DW PCIe core reviewer > MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer > MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list > MAINTAINERS: Add myself as the DW eDMA driver reviewer > > MAINTAINERS | 11 ++++-- > drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- > .../pci/controller/dwc/pcie-designware-host.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.c | 2 - > drivers/pci/controller/dwc/pcie-designware.h | 7 +++- > drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- > 6 files changed, 34 insertions(+), 30 deletions(-) > > -- > 2.40.0 > >
