On 4/5/23 8:15 PM, Jason Gunthorpe wrote:
On Fri, Mar 31, 2023 at 04:11:37PM -0700, Jacob Pan wrote:static void idxd_disable_system_pasid(struct idxd_device *idxd) { + struct pci_dev *pdev = idxd->pdev; + struct device *dev = &pdev->dev; + struct iommu_domain *domain; + union gencfg_reg gencfg; + + domain = iommu_get_domain_for_dev(dev); + if (!domain || domain->type == IOMMU_DOMAIN_BLOCKED) + return; + + iommu_detach_device_pasid(domain, dev, idxd->pasid);This sequence is kinda weird, we shouldn't pass in domain to detach_device_pasid, IMHO. We already know the domain because we store it in an xarray, it just creates weirdness if the user passes in the wrong domain.
The initial idea was that the driver has a domain and it wants to attach the domain to a pasid of the device. During attaching, iommu core will save the domain in its xarray. After use, driver want to detach the domain from the pasid by calling iommu_detach_device_pasid(). The iommu core will compare the input domain and the one it saved. A warning will be triggered if they are different. WARN_ON(xa_erase(&group->pasid_array, pasid) != domain); Logically speaking, @domain for detach_device_pasid is unnecessary, because the pasid array is essentially per-device (as we discussed before. the pci_enable_pasid() ensures this), although it is currently placed in the group structure. In that case, the driver can and should own everything about the pasid and domain. The roles of the iommu core and the individual driver are only to handle requests of installing or withdrawing a domain on/from a device's pasid. Best regards, baolu
