Hi Herbert, On Fri, 2023-03-17 at 10:51 +0800, Herbert Xu wrote: > On Mon, Mar 06, 2023 at 12:52:22PM -0600, Tom Zanussi wrote: > > > > +static struct crypto_alg iaa_comp_deflate = { > > + .cra_name = "deflate", > > + .cra_driver_name = "iaa_crypto", > > + .cra_flags = CRYPTO_ALG_TYPE_COMPRESS, > > + .cra_priority = IAA_ALG_PRIORITY, > > + .cra_module = THIS_MODULE, > > + .cra_u = { > > + .compress = { > > + .coa_compress = iaa_comp_compress, > > + .coa_decompress = iaa_comp_decompress > > + } > > + } > > +}; > > Please add any new code using the legacy compression interface. > We're trying to phase them out. > > If your user is still using the legacy interface, they should > be converted instead. > OK, I'll just remove this interface. It was added so IAA could be used with zram, which still uses the old interface. I'll play around with seeing what it would take to get zram to use the async interface ala zswap, but I'm guessing there may be a reason it hasn't been converted yet... Thanks, Tom > Thanks,