> From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> > Sent: Thursday, March 9, 2023 10:57 AM > > @@ -4650,7 +4650,18 @@ static int intel_iommu_enable_sva(struct device > *dev) > if (!(iommu->flags & VTD_FLAG_SVM_CAPABLE)) > return -ENODEV; > > - if (!info->pasid_enabled || !info->pri_enabled || !info->ats_enabled) > + if (!info->pasid_enabled) > + return -EINVAL; > + I think you still want to check ats_enabled even for device specific IOPF.