Re: [PATCH v4 2/6] iommu/sva: Move PASID helpers to sva code

[Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>]

Hi Kevin,

On Thu, 2 Mar 2023 09:03:52 +0000, "Tian, Kevin" <kevin.tian@xxxxxxxxx>
wrote:

> > From: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > Sent: Thursday, March 2, 2023 7:57 AM
> >
> > -static inline void mm_pasid_drop(struct mm_struct *mm)
> > -{
> > -	if (pasid_valid(mm->pasid)) {
> > -		ioasid_free(mm->pasid);
> > -		mm->pasid = INVALID_IOASID;
> > -	}
> > -}
> > +void mm_pasid_drop(struct mm_struct *mm);  
> 
> Is it good to have a function declared in a header file of one
> subsystem while being implemented in another subsystem?
Good point!  I will move it to iommu_helper.h

Thanks,

Jacob