>>>>> "Yang" == Yang Yingliang <yangyingliang@xxxxxxxxxx> writes:
> devm_ioremap_resource() never returns NULL pointer, it will return
> ERR_PTR() when it fails, so replace the check with IS_ERR().
> Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Acked-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>
> ---
> drivers/dma/xilinx/xdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 462109c61653..1c836cbdafa1 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,8 +892,9 @@ static int xdma_probe(struct platform_device *pdev)
> }
> reg_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!reg_base) {
> + if (IS_ERR(reg_base)) {
> xdma_err(xdev, "ioremap failed");
> + ret = PTR_ERR(reg_base);
> goto failed;
> }
> --
> 2.25.1
--
Bye, Peter Korsgaard
