Thanks for the review! > On 14. 2. 2023, at 20:25, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Feb 14, 2023 at 03:10:53PM +0100, Martin Povišer wrote: >> Describe the SIO coprocessor which serves as pretend DMA controller on >> recent Apple platforms. >> >> Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx> >> --- >> >> Since the schema mentions a loader preparing the binding appropriately, >> here's a PR with the relevant (WIP) loader code, if anyone wants to look: >> https://github.com/AsahiLinux/m1n1/pull/286 >> >> .../devicetree/bindings/dma/apple,sio.yaml | 129 ++++++++++++++++++ >> 1 file changed, 129 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/dma/apple,sio.yaml >> >> diff --git a/Documentation/devicetree/bindings/dma/apple,sio.yaml b/Documentation/devicetree/bindings/dma/apple,sio.yaml >> new file mode 100644 >> index 000000000000..a76cc8265e76 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/dma/apple,sio.yaml (...) >> + memory-region: >> + description: >> + A number of references to reserved memory regions among which are the DATA/TEXT >> + sections of coprocessor executable firmware and also auxiliary firmware data >> + describing the available DMA-enabled peripherals > > Can you define some range of number of entries. I think I can provide a reliable lower bound (at least one segment with DATA/TEXT and one segment with auxiliary data), and a conservative upper bound (separate DATA/TEXT and no more than 6 segments of auxiliary data if each kind of data has a segment of its own). I will work it in into the next version. Martin
