Re: [PATCH] dmaengine: tegra210-adma: fix global intr clear

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26-12-22, 12:21, Mohan Kumar wrote:
> The current global interrupt clear programming register offset
> was not correct. Fix the programming with right offset
> 
> fixes: 'commit ded1f3db4cd6
> 	("dmaengine: tegra210-adma: prepare for supporting newer Tegra chips")'

Ugh, this is not the format for fixes tag, see Documentation/process/5.Posting.rst
> 
> Signed-off-by: Mohan Kumar <mkumard@xxxxxxxxxx>

Why did you CC stable for this email? Again read the process!

> ---
>  drivers/dma/tegra210-adma.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index ae39b52012b2..487f8fb411b5 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -221,7 +221,9 @@ static int tegra_adma_init(struct tegra_adma *tdma)
>  	int ret;
>  
>  	/* Clear any interrupts */
> -	tdma_write(tdma, tdma->cdata->global_int_clear, 0x1);
> +	tdma_write(tdma,
> +		   tdma->cdata->ch_base_offset + tdma->cdata->global_int_clear,
> +		   0x1);

This looks _very_ ugly, one line should look and read better:
        tdma_write(tdma, tdma->cdata->ch_base_offset + tdma->cdata->global_int_clear, 0x1);
We are no longer 80 char limited!

-- 
~Vinod



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux