On Wed, Nov 30, 2022 at 05:08:00PM +0800, Hui Wang wrote: > If the function sdma_load_context() fails, the sdma_desc will be > freed, but the allocated desc->bd is forgot to be freed. > > We already met the sdma_load_context() failure case and the log as > below: > [ 450.699064] imx-sdma 30bd0000.dma-controller: Timeout waiting for CH0 ready > ... > > In this case, the desc->bd will not be freed without this change. > > Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx> > --- > drivers/dma/imx-sdma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> Sascha > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index fbea5f62dd98..b926abe4fa43 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1521,10 +1521,12 @@ static struct sdma_desc *sdma_transfer_init(struct sdma_channel *sdmac, > sdma_config_ownership(sdmac, false, true, false); > > if (sdma_load_context(sdmac)) > - goto err_desc_out; > + goto err_bd_out; > > return desc; > > +err_bd_out: > + sdma_free_bd(desc); > err_desc_out: > kfree(desc); > err_out: > -- > 2.34.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
