Re: [PATCH] dmaengine: ste_dma40: add missing free_irq() in error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] dmaengine: ste_dma40: add missing free_irq() in error path
From: Linus Walleij <linus.walleij@xxxxxxxxxx>
Date: Tue, 15 Nov 2022 23:12:58 +0100
In-reply-to: <20221115081546.2389164-1-ruanjinjie@huawei.com>
References: <20221115081546.2389164-1-ruanjinjie@huawei.com>

On Tue, Nov 15, 2022 at 9:19 AM ruanjinjie <ruanjinjie@xxxxxxxxxx> wrote:

> free_irq() is missing in some cases of error in d40_probe(), fix that.
>
> Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx>

Correct, but ... please just convert it to use
devm_request_irq() instead. Less lines of code.

Yours,
Linus Walleij

References:
- [PATCH] dmaengine: ste_dma40: add missing free_irq() in error path
  - From: ruanjinjie

Prev by Date: Re: [PATCH v10 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema
Next by Date: Re: [PATCH V2] dmaengine: Fix client_count is countered one more incorrectly.
Previous by thread: [PATCH] dmaengine: ste_dma40: add missing free_irq() in error path
Next by thread: [PATCH v10 0/2] dmaengine: sdma support hdmi audio
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux PCI] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]

Powered by Linux