On 20-10-22, 10:10, Jiapeng.Chong wrote: > The report is the link, which can be seen in the submitted patch description. Thank you. Pls dont top post! > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430 This bug says: "ABACI reported the following bug by code static scanning" Where is the ABACI report? > ------------------------------------------------------------------ > 发件人:Vinod Koul <vkoul@xxxxxxxxxx> > 发送时间:2022年10月19日(星期三) 21:46 > 收件人:Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > 抄 送:peter.ujfalusi <peter.ujfalusi@xxxxxxxxx>; dmaengine <dmaengine@xxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > 主 题:Re: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and() > On 18-10-22, 16:38, Jiapeng Chong wrote: > > The function edma_and() is defined in the edma.c file, but not called > > elsewhere, so remove this unused function. > > > > drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'. > > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430 > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Where is this report? > > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > > --- > > drivers/dma/ti/edma.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c > > index fa06d7e6d8e3..9ea91c640c32 100644 > > --- a/drivers/dma/ti/edma.c > > +++ b/drivers/dma/ti/edma.c > > @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and, > > edma_write(ecc, offset, val); > > } > > > > -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and) > > -{ > > - unsigned val = edma_read(ecc, offset); > > - > > - val &= and; > > - edma_write(ecc, offset, val); > > -} > > - > > static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or) > > { > > unsigned val = edma_read(ecc, offset); > > -- > > 2.20.1.7.g153144c > -- > ~Vinod -- ~Vinod