> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: 2022年11月3日 21:54 > To: Joy Zou <joy.zou@xxxxxxx>; vkoul@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; > s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx > Cc: S.J. Wang <shengjiu.wang@xxxxxxx>; martink@xxxxxxxxx; > dev@xxxxxxxxxx; alexander.stein@xxxxxxxxxxxxxxx; Peng Fan > <peng.fan@xxxxxxx>; david@xxxxxxx; aford173@xxxxxxxxx; Hongxing Zhu > <hongxing.zhu@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > dmaengine@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH v9 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma > to DT schema > > Caution: EXT Email > > On 31/10/2022 06:50, Joy Zou wrote: > > Convert the i.MX SDMA binding to DT schema format using json-schema. > > > > The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma, > > fsl,imx35-to1-sdma and fsl,imx35-to2-sdma are not used. So need to > > delete it. The compatibles fsl,imx50-sdma, fsl,imx6sll-sdma and > > fsl,imx6sl-sdma are added. The original binding don't list all compatible used. > > > > In addition, add new peripheral types HDMI Audio. > > > > Signed-off-by: Joy Zou <joy.zou@xxxxxxx> > > --- > > Changes in v9: > > add the dma-common quotes. > > delete the dma-controller quotes. > > I have no clue what you are doing here... Do you know what are "quotes"? > I linked last time explanation of "quotes", so did you read it? Thank you very much for your comments. I confused quote and quotes. Could I confirm my understand？ The quote means $ref: ? The quotes means a symbol "? > > > > > > Changes in v8: > > add the dma-controller quotes. > > delete #dma-cells in required. > > > > Changes in v6: > > delete tag Acked-by from commit message. > > > > Changes in v5: > > modify the commit message fromat. > > add additionalProperties, because delete the quotes in patch v4. > > delete unevaluatedProperties due to similar to additionalProperties. > > modification fsl,sdma-event-remap items and description. > > > > Changes in v4: > > modify the commit message. > > delete the quotes in patch. > > modify the compatible in patch. > > delete maxitems and add items for clock-names property. > > add iram property. > > > > Changes in v3: > > modify the commit message. > > modify the filename. > > modify the maintainer. > > delete the unnecessary comment. > > modify the compatible and run dt_binding_check and dtbs_check. > > add clocks and clock-names property. > > delete the reg description and add maxItems. > > delete the interrupts description and add maxItems. > > add ref for gpr property. > > modify the fsl,sdma-event-remap ref type and add items. > > delete consumer example. > > > > Changes in v2: > > convert imx sdma bindings to DT schema. > > --- > > .../devicetree/bindings/dma/fsl,imx-sdma.yaml | 149 > > ++++++++++++++++++ .../devicetree/bindings/dma/fsl-imx-sdma.txt | > > 118 -------------- > > 2 files changed, 149 insertions(+), 118 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt > > > > diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > new file mode 100644 > > index 000000000000..95d0391a1f39 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > @@ -0,0 +1,149 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fdma%2Ffsl%2Cimx-sdma.yaml%23&data=05 > %7C01% > > > +7Cjoy.zou%40nxp.com%7Cd8f785d11ac042ebd7d908dabda2d753%7C686ea > 1d3bc2b > > > +4c6fa92cd99c5c301635%7C0%7C0%7C638030804342124191%7CUnknown > %7CTWFpbGZ > > > +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > n0% > > > +3D%7C3000%7C%7C%7C&sdata=3XpKUGv751na%2BV4OYDQEvGQxeeT > 4UbW0wizQkM > > +yfx4k%3D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cjoy.z > ou%4 > > > +0nxp.com%7Cd8f785d11ac042ebd7d908dabda2d753%7C686ea1d3bc2b4c6 > fa92cd99 > > > +c5c301635%7C0%7C0%7C638030804342124191%7CUnknown%7CTWFpbG > Zsb3d8eyJWIj > > > +oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7 > > > +C%7C%7C&sdata=nnBXK4c%2FiA1ncohiak4CXEQGbp5uhDq835RK9%2B > BYdJw%3D& > > +amp;reserved=0 > > + > > +title: Freescale Smart Direct Memory Access (SDMA) Controller for > > +i.MX > > + > > +maintainers: > > + - Joy Zou <joy.zou@xxxxxxx> > > + > > +allOf: > > + - $ref: dma-common.yaml# > > That's wrong. This should be dma-controller. Why this was changed? Thank you very much for your comments. I remember your comments in patch v6. "The device schemas do not need to enforce the name. The dma-controller schema enforces it, so what is missing here is to reference it." So I change it. Should I use dma-controller? BR Joy Zou > > > > Best regards, > Krzysztof
