On 24-05-22, 13:19, Radhey Shyam Pandey wrote: > From: Shravya Kumbham <shravya.kumbham@xxxxxxxxxx> > > Typecast the flags variable with (enum dma_ctrl_flags) in > zynqmp_dma_prep_memcpy function to fix the coverity warning. Applied, thanks > > Addresses-Coverity: Event mixed_enum_type. > Signed-off-by: Shravya Kumbham <shravya.kumbham@xxxxxxxxxx> > Signed-off-by: Harini Katakam <harini.katakam@xxxxxxxxxx> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx> > --- > NOTE- This patch was sent to dmaengine mailing list[1] and > there was a suggestion from Michael Tretter to change the > signature of the dmaengine_prep_dma_memcpy() engine to accept > "enum dma_ctrl_flags flags" instead of "unsigned long flags". > > All device_prep_dma_* API variants have ulong flags argument. > So this is a wider question if we want to change these APIs? > Also there are existing users of these public APIs. It would be very nice to do this change but users would need to be updated as well, patches are welcome -- ~Vinod
