> On 15. 6. 2022, at 19:10, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Wed, Jun 15, 2022 at 6:28 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: >> On 6/14/22 23:01, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20220614: >>> >> >> on i386: >> >> ../drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc': >> ../drivers/dma/apple-admac.c:213:22: warning: right shift count >= width of type [-Wshift-count-overflow] >> writel_relaxed(addr >> 32, ad->base + REG_DESC_WRITE(channo)); >> ^ > > This should probably use lower_32_bits()/upper_32_bits() then. > > Arnd Here’s a patch to use lower/upper_32_bits that’s been posted. https://lore.kernel.org/dmaengine/20220614074915.1443629-1-geert@xxxxxxxxxxxxxx/ Martin