On 10-06-22, 10:01, Vinod Koul wrote:
> We get a warning (treated as error now)
> drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
> drivers/dma/apple-admac.c:209:26: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
> 209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
>
> Use %lx for priniting the flag
I have picked this one
>
> Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
added bot as report too
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> ---
> drivers/dma/apple-admac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
> index 2425069c186d..c502f8c3aca7 100644
> --- a/drivers/dma/apple-admac.c
> +++ b/drivers/dma/apple-admac.c
> @@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
> /* If happens means we have buggy code */
> WARN_ON_ONCE(addr + tx->period_len > tx->buf_end);
>
> - dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
> + dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n",
> channo, &addr, tx->period_len, FLAG_DESC_NOTIFY);
>
> writel_relaxed(addr, ad->base + REG_DESC_WRITE(channo));
> --
> 2.34.3
--
~Vinod
