Re: [PATCH] dmaengine: idxd: add RO check for wq max_batch_size write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11-04-22, 15:08, Dave Jiang wrote:
> Block wq_max_batch_size_store() when the device is configured as read-only
> and not configurable.

Applied, thanks

> 
> Fixes: e7184b159dd3 ("dmaengine: idxd: add support for configurable max wq batch size")
> Reported-by: Bernice Zhang <bernice.zhang@xxxxxxxxx>
> Tested-by: Bernice Zhang <bernice.zhang@xxxxxxxxx>
> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
>  drivers/dma/idxd/sysfs.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index ec13ca4808f9..dfd549685c46 100644
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -942,6 +942,9 @@ static ssize_t wq_max_batch_size_store(struct device *dev, struct device_attribu
>  	u64 batch_size;
>  	int rc;
>  
> +	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
> +		return -EPERM;
> +
>  	if (wq->state != IDXD_WQ_DISABLED)
>  		return -EPERM;
>  
> 

-- 
~Vinod



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux