On 18-04-22, 22:19, Yunbo Yu wrote: > It is unnecessary to call spin_lock_bh() for that you are already in a if you are > taselet. tasklet > > Signed-off-by: Yunbo Yu <yuyunbo519@xxxxxxxxx> > --- > drivers/dma/mv_xor_v2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c > index 9c8b4084ba2f..f10b29034da1 100644 > --- a/drivers/dma/mv_xor_v2.c > +++ b/drivers/dma/mv_xor_v2.c > @@ -591,14 +591,14 @@ static void mv_xor_v2_tasklet(struct tasklet_struct *t) > dma_run_dependencies(&next_pending_sw_desc->async_tx); > > /* Lock the channel */ > - spin_lock_bh(&xor_dev->lock); > + spin_lock(&xor_dev->lock); > > /* add the SW descriptor to the free descriptors list */ > list_add(&next_pending_sw_desc->free_list, > &xor_dev->free_sw_desc); > > /* Release the channel */ > - spin_unlock_bh(&xor_dev->lock); > + spin_unlock(&xor_dev->lock); > > /* increment the next descriptor */ > pending_ptr++; > -- > 2.25.1 -- ~Vinod
