On 2022-04-18 08:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
>
> Signed-off-by: Yunbo Yu <yuyunbo519@xxxxxxxxx>
Ah, thanks!
Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> ---
> drivers/dma/plx_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> struct plx_dma_desc *desc;
> u32 flags;
>
> - spin_lock_bh(&plxdev->ring_lock);
> + spin_lock(&plxdev->ring_lock);
>
> while (plxdev->tail != plxdev->head) {
> desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> plxdev->tail++;
> }
>
> - spin_unlock_bh(&plxdev->ring_lock);
> + spin_unlock(&plxdev->ring_lock);
> }
>
> static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
