From: Minghao Chi <chi.minghao@xxxxxxxxxx> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and pm_runtime_put_noidle. This change is just to simplify the code, no actual functional changes. Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx> --- drivers/dma/ti/cppi41.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c index 062bd9bd4de0..44363a731409 100644 --- a/drivers/dma/ti/cppi41.c +++ b/drivers/dma/ti/cppi41.c @@ -374,11 +374,10 @@ static int cppi41_dma_alloc_chan_resources(struct dma_chan *chan) struct cppi41_dd *cdd = c->cdd; int error; - error = pm_runtime_get_sync(cdd->ddev.dev); + error = pm_runtime_resume_and_get(cdd->ddev.dev); if (error < 0) { dev_err(cdd->ddev.dev, "%s pm runtime get: %i\n", __func__, error); - pm_runtime_put_noidle(cdd->ddev.dev); return error; } @@ -402,12 +401,9 @@ static void cppi41_dma_free_chan_resources(struct dma_chan *chan) struct cppi41_dd *cdd = c->cdd; int error; - error = pm_runtime_get_sync(cdd->ddev.dev); - if (error < 0) { - pm_runtime_put_noidle(cdd->ddev.dev); - + error = pm_runtime_resume_and_get(cdd->ddev.dev); + if (error < 0) return; - } WARN_ON(!list_empty(&cdd->pending)); -- 2.25.1