RE: [PATCH] dt-bindings: dma: rz-dmac: Update compatible string for RZ/G2UL SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH] dt-bindings: dma: rz-dmac: Update compatible string
> for RZ/G2UL SoC
> 
> Hi Biju,
> 
> On Thu, Mar 3, 2022 at 10:02 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Both RZ/G2UL and RZ/Five SoC's have SoC ID starting with R9A07G043.
> > To distinguish between them update the compatible string to
> > "renesas,r9a07g043u-dmac" for RZ/G2UL SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> > @@ -16,9 +16,9 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > -          - renesas,r9a07g043-dmac # RZ/G2UL
> > -          - renesas,r9a07g044-dmac # RZ/G2{L,LC}
> > -          - renesas,r9a07g054-dmac # RZ/V2L
> > +          - renesas,r9a07g043u-dmac # RZ/G2UL
> 
> Is this really needed? As far as we know, RZ/Five and RZ/G2UL do use the
> same I/O blocks?

OK, Just thought their DEVID is different and they use RISC-V instead of ARM64
And also the CPU caches are different.

I agree it uses identical IP blocks.

May be I can drop this patch, if it is not really needed. Please let me know.

Cheers,
Biju

> 
> > +          - renesas,r9a07g044-dmac  # RZ/G2{L,LC}
> > +          - renesas,r9a07g054-dmac  # RZ/V2L
> >        - const: renesas,rz-dmac
> >
> >    reg:
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux