Hi Rob, robh@xxxxxxxxxx wrote on Fri, 25 Feb 2022 12:32:51 -0600: > On Fri, Feb 18, 2022 at 07:12:21PM +0100, Miquel Raynal wrote: > > The dmamux register is located within the system controller. > > > > Without syscon, we need an extra helper in order to give write access to > > this register to a dmamux driver. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > --- > > drivers/clk/renesas/r9a06g032-clocks.c | 27 +++++++++++++++++++ > > include/dt-bindings/clock/r9a06g032-sysctrl.h | 2 ++ > > include/linux/soc/renesas/r9a06g032-syscon.h | 11 ++++++++ > > 3 files changed, 40 insertions(+) > > create mode 100644 include/linux/soc/renesas/r9a06g032-syscon.h > > > diff --git a/include/dt-bindings/clock/r9a06g032-sysctrl.h b/include/dt-bindings/clock/r9a06g032-sysctrl.h > > index 90c0f3dc1ba1..609e7fe8fcb1 100644 > > --- a/include/dt-bindings/clock/r9a06g032-sysctrl.h > > +++ b/include/dt-bindings/clock/r9a06g032-sysctrl.h > > @@ -145,4 +145,6 @@ > > #define R9A06G032_CLK_UART6 152 > > #define R9A06G032_CLK_UART7 153 > > > > +#define R9A06G032_SYSCON_DMAMUX 0xA0 > > That looks like a register offset? We generally don't put register > offsets in DT. This is a leftover, the offset is defined somewhere else now, I will fix this. > > > + > > #endif /* __DT_BINDINGS_R9A06G032_SYSCTRL_H__ */ Thanks, Miquèl
