On Mon, Feb 21, 2022 at 04:13:20PM +0100, Miquel Raynal wrote: > andriy.shevchenko@xxxxxxxxxxxxxxx wrote on Sun, 20 Feb 2022 12:56:02 > +0200: > > On Fri, Feb 18, 2022 at 07:12:22PM +0100, Miquel Raynal wrote: ... > > > + dev_err(&pdev->dev, "Missing DMAC requests information\n"); > > > + of_node_put(dmac_node); > > > + return -EINVAL; > > > > First put node, then simply use dev_err_probe(). > > I don't get the point here. dev_err_probe() is useful when -EPROBE_DEFER > can be returned, right? I don't understand what it would bring here nor > how I should use it to simplify error handling. Less LOCs, and it's fine to call it here. This usecase is described in the dev_err_probe() documentation. -- With Best Regards, Andy Shevchenko
