Hi Geert,
Thank you for the review.
On Tue, Jan 11, 2022 at 4:23 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Tue, Dec 21, 2021 at 10:48 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Add SCIF binding documentation for Renesas RZ/V2L SoC. SCIF block on RZ/V2L
> > is identical to one found on the RZ/G2L SoC. No driver changes are required
> > as RZ/G2L compatible string "renesas,scif-r9a07g044" will be used as a
> > fallback.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > @@ -67,6 +67,12 @@ properties:
> > - items:
> > - enum:
> > - renesas,scif-r9a07g044 # RZ/G2{L,LC}
> > + - renesas,scif-r9a07g054 # RZ/V2L
>
> As the idea is to rely on the RZ/G2L fallback for matching, cfr. below,
> the above addition is not needed or wanted.
>
Agreed I will drop that.
> > +
> > + - items:
> > + - enum:
> > + - renesas,scif-r9a07g054 # RZ/V2L
> > + - const: renesas,scif-r9a07g044 # RZ/G2{L,LC} fallback for RZ/V2L
> >
> > reg:
> > maxItems: 1
> > @@ -154,6 +160,7 @@ if:
> > - renesas,rcar-gen2-scif
> > - renesas,rcar-gen3-scif
> > - renesas,scif-r9a07g044
> > + - renesas,scif-r9a07g054
>
> This addition is not needed if the fallback is always present.
>
Ditto.
> > then:
> > required:
> > - resets
>
> Given Greg already applied your patch, I think you have to send a
> follow-up patch.
Will do.
Cheers,
Prabhakar
