On Mon, Dec 06, 2021 at 11:42:26AM -0600, Rob Herring wrote:
> The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id'
> properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties'
> support is enabled, a the follow warning is generated:
s/a the following/the following/
Otherwise looks good:
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
One question below...
>
> Documentation/devicetree/bindings/dma/ti/k3-bcdma.example.dt.yaml: dma-controller@485c0100: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)
> Documentation/devicetree/bindings/dma/ti/k3-pktdma.example.dt.yaml: dma-controller@485c0000: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)
>
> Add a reference to ti,k3-sci-common.yaml to fix this.
>
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
> Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> Cc: dmaengine@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 1 +
> Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> index df29d59d13a8..08627d91e607 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> @@ -30,6 +30,7 @@ description: |
>
> allOf:
> - $ref: /schemas/dma/dma-controller.yaml#
> + - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
Out of curiosity: is the # at the end necessary, or do you just use it
as a convention? I've seen a mix of both and there also seems to be a
healthy mix of quoted and unquoted paths. Do we want to settle on one
going forward or do we not care enough?
Thierry
Attachment:
signature.asc
Description: PGP signature
