Hi Dongliang,
Thanks for your patch!
On Wed, Oct 20, 2021 at 4:36 PM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote:
> In rcar_dmac_probe, if pm_runtime_resume_and_get fails, it forgets to
> disable runtime PM. And of_dma_controller_free should only be invoked
> after the success of of_dma_controller_register.
The second issue is actually harmless, as of_dma_controller_free()
is a no-op if the DMA controller was never registered.
Of course it doesn't hurt to improve symmetry.
> Fix this by refactoring the error handling code.
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
