On Mon, Sep 20, 2021 at 07:00:58PM -0500, Gustavo A. R. Silva wrote: > > > On 9/18/21 05:40, Len Baker wrote: > > As noted in the "Deprecated Interfaces, Language Features, Attributes, > > and Conventions" documentation [1], size calculations (especially > > multiplication) should not be performed in memory allocator (or similar) > > function arguments due to the risk of them overflowing. This could lead > > to values wrapping around and a smaller allocation being made than the > > caller was expecting. Using those allocations could lead to linear > > overflows of heap memory and other misbehaviors. > > > > So, use the struct_size() helper to do the arithmetic instead of the > > argument "size + count * size" in the kzalloc() function. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments > > > > Signed-off-by: Len Baker <len.baker@xxxxxxx> > > Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> I'm taking this in my -next tree. Thanks -- Gustavo
