On 20-06-21, 11:41, Sanjay R Mehta wrote: > From: Sanjay R Mehta <sanju.mehta@xxxxxxx> > > Register ptdma queue to Linux dmaengine framework as general-purpose > DMA channels. Mostly looks good, one question below: > +static struct pt_dma_desc *pt_alloc_dma_desc(struct pt_dma_chan *chan, > + unsigned long flags) > +{ > + struct pt_dma_desc *desc; > + > + desc = kmem_cache_zalloc(chan->pt->dma_desc_cache, GFP_NOWAIT); > + if (!desc) > + return NULL; > + > + vchan_tx_prep(&chan->vc, &desc->vd, flags); > + > + desc->pt = chan->pt; > + desc->issued_to_hw = 0; > + desc->status = DMA_IN_PROGRESS; where is this descriptor freed? -- ~Vinod