Hi Vinod, Thanks for review, Please check for in-line response for the comments Regards Pandith > -----Original Message----- > From: Vinod Koul <vkoul@xxxxxxxxxx> > Sent: Wednesday, July 14, 2021 10:20 AM > To: N, Pandith <pandith.n@xxxxxxxxx> > Cc: Eugeniy.Paltsev@xxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; Raja > Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@xxxxxxxxx>; Pan, Kris > <kris.pan@xxxxxxxxx>; Sangannavar, Mallikarjunappa > <mallikarjunappa.sangannavar@xxxxxxxxx>; Thokala, Srikanth > <srikanth.thokala@xxxxxxxxx> > Subject: Re: [linux-drivers-review] [PATCH V2 1/1] dmaengine: dw-axi-dmac: > support parallel memory <--> peripheral transfers > > On 09-07-21, 15:21, pandith.n@xxxxxxxxx wrote: > > From: Pandith N <pandith.n@xxxxxxxxx> > > > > Added support for multiple DMA_MEM_TO_DEV, DMA_DEV_TO_MEM > transfers in > > parallel. This is required for peripherals using DMA for transmit and > > receive operations at the same time. APB slot number needs to be > > programmed in channel hardware handshaking interface. > > > > Removed free slot check algorithm in dw_axi_dma_set_hw_channel. For 8 > > DMA channels, use respective handshake slot in DMA_HS_SEL APB register. > > and why was that removed, maybe a different patch for that? > For every channel, an dedicated slot is provided in hardware handshake register. Peripheral source number is programmed in respective channel slots. > > > > Burst length, DMA HW capability set in dt-binding is now used in driver. > > Another patch... > > So, too many changes below for the description above, pls split > I will split the changes as separate patches in next version. > -- > ~Vinod
