On Thu, Jun 24, 2021 at 04:46:32PM +0530, Vinod Koul wrote: > On 14-06-21, 16:30, Andy Shevchenko wrote: > > Intel Elkhart Lake PSE DMA implementation is integrated with crossbar IP > > in order to serve more hardware than there are DMA request lines available. > > > > Due to this, program xBAR hardware to make flexible support of PSE peripheral. > > > > The Device-to-Device has not been tested and it's not supported by DMA Engine, > > but it's left in the code for the sake of documenting hardware features. > > Kernel does not like to keep dead code, please remove this. It can be > added back when we have users I would rather keep it as documentation (converted to comment perhaps). In any case, it seems the suitable point of time to contribute will be already after v5.14-rc1. -- With Best Regards, Andy Shevchenko