Re: [PATCH -next] dmaengine: at_xdmac: Remove unused inline function at_xdmac_csize()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/6/21 11:50 AM, YueHaibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")
> left behind this, so can remove it.

Checkpatch complains:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 765c37d87669 ("dmaengine: at_xdmac: rework slave configuration part")'

but the change is good:
Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  drivers/dma/at_xdmac.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index fe45ad5d06c4..64a52bf4d737 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -344,17 +344,6 @@ static inline int at_xdmac_chan_is_paused(struct at_xdmac_chan *atchan)
>         return test_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
>  }
> 
> -static inline int at_xdmac_csize(u32 maxburst)
> -{
> -       int csize;
> -
> -       csize = ffs(maxburst) - 1;
> -       if (csize > 4)
> -               csize = -EINVAL;
> -
> -       return csize;
> -};
> -
>  static inline bool at_xdmac_chan_is_peripheral_xfer(u32 cfg)
>  {
>         return cfg & AT_XDMAC_CC_TYPE_PER_TRAN;
> --
> 2.17.1
> 





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux